Improve pxr CMake Config support by using CMakeFindDependencyMacro CMake module instead of raw find_package
#3205
Conversation
…CMake module instead of raw `find_package`
|
Filed as internal issue #USD-9932 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
It looks like the Linux build went through but the CI was cancelled, any idea what went wrong ? |
|
@theblackunknown It looks like the build succeeded but there was some kind of hiccup on the Azure side of things. I requeued the job to double-check. |
|
Hi @sunyab what are my chances to integrate my change for the next release ? |
|
Maybe #3310 can be included in this? Currently unable to build f3d as it depends on usd which then depends on materialx. Fails at OpenGL since nothing includes it in the cmake. Manually adding |
Looking at your issue @parkerlreed, I think I know what is going on and this requires further improvements which are currently not in this PR. |
5 participants
Description of Change(s)
This PR improves the
pxrCMake Config supports by usingfind_dependencyfromCMakeFindDependencyMacroCMake module instead of rawfind_package.Doing so handling of
REQUIREDis not needing anymore as it will be transively forwarded from thefind_pckage(pxr ...)calls:find_package(pxr REQUIRED ...)results in dependencies being required toofind_package(pxr ...)results in dependencies being optional tooMore information on
CMakeFindDependencyMacroCMake module documentation page.